RayCluster with create_settings #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-rigazzi
added
type: feature
Spartee
suggested changes
Dec 21, 2021
Spartee
reviewed
Jan 11, 2022
smartsim/launcher/lsf/lsfLauncher.py
Outdated
| @@ -26,6 +26,8 @@ | |||
|
|
|||
| import time | |||
|
|
|||
| from smartsim.settings.settings import RunSettings | |||
Spartee
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we change the way Ray is started (internally): instead of creating
SrunSettings,AprunSettings, andMpirunSettingsobjects, we just create aBaseRunSettingsobject with the correctrun_command. The same holds for batch settings.Also, notably, this automatically adds support for
Cobaltas a launcher.